LAION-AI/Open-Assistant

Enable Typescript strict mode

Open

#879 opened on Jan 21, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (37,363 stars) (3,263 forks)batch import
good first issuewebsite

Description

We need to enable Typescript strict mode to make out code safe. This needs to be incremental cause we don't want to break the build.

  • Set TS strict option to true in the tsconfig file.
  • Going through each file and checking if there is any error need to fix (or run npm run typecheck).

We should make small PRs to easily review and avoid conflict.

Contributor guide

Tech stack
typescript
Domain
developer experiencetooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScriptnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
First, set the 'strict' option to true in tsconfig.json. Then run `npm run typecheck` to identify errors in each file. Create separate PRs for fixing errors in each file to keep changes small and reviewable. The issue comments might provide guidance on prioritization.