LAION-AI/Open-Assistant

Handle edge case search queries better

Open

#3259 opened on May 29, 2023

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Python (37,363 stars) (3,263 forks)batch import
backendgood first issue

Description

We should do some preprocessing of search_query here to prevent errors in edge cases, e.g. where the query ends with an operator like & or |.

Words separated by only a space and no operator also have no effect currently, we could modify these such that & is inserted automatically.

List of valid operations I am aware of:

&
|
<->
!

The syntax also allows combinations like &! and groupings via parantheses.

https://github.com/LAION-AI/Open-Assistant/blob/main/backend/oasst_backend/prompt_repository.py#L1023

Contributor guide

Tech stack
python
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python basicsstring manipulationunderstanding of search operators
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the function at backend/oasst backend/prompt repository.py line 1023 to understand current search query handling. Identify the parsing logic for operators (&, |, < >, !) and how the query is processed. Consider edge cases like trailing operators and missing operators between words. The comments may contain additional discussion about desired behavior. Implement preprocessing to sanitize the query and insert '&' where appropriate.