Kureev/react-native-side-menu

You can open a sidemenu from the sidemenu

Open

#304 opened on Jul 22, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,222 stars) (442 forks)batch import
feedback neededhelp wanted

Description

First off, thank you for making this!!

However, I have some issues that I might have not expected.

Is this behavior expected? I can basically swipe right while having the side menu open and it will open another component.

Also the sidemenu content overlaps with the main component. Is that the default behavior?

EDIT: I fixed the content overlapping by giving the main component a style of backgorundColor: 'white'. Still feels a bit hacky.

jul-22-2017 15-08-36

Contributor guide

Tech stack
react nativejavascript
Domain
mobilefrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React Native basicsgesture handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Examine the side menu component's swipe gesture handler in the main file (e.g., index.js). Look for logic that disables swipe when the menu is already open. Also check the layout to ensure the main content does not overlap with the menu without relying on backgroundColor. Consider using state to disable gesture recognition when menu is visible.