Kureev/react-native-navbar

Receiving an warning/error for props to left or right button

Open

#175 opened on Jun 7, 2016

View on GitHub
 (4 comments) (2 reactions) (0 assignees)JavaScript (1,900 stars) (319 forks)batch import
help wantedwaiting for feedback

Description

Whenever I try to implement the left or right buttons I am getting a warning. It still works but I would prefer the error not be there. One example of the error is

ExceptionsManager.js:71 Warning: Failed propType: Invalid prop `title` of type `object` supplied to `NavbarButton`, expected `string`. Check the render method of `NavigationBar`.

Contributor guide

Tech stack
javascriptreact native
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React Native basicsPropTypes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue is a prop type warning where the title prop of NavbarButton expects a string but receives an object. To fix, look at the NavbarButton component's propTypes definition (likely in NavbarButton.js) and ensure the title prop is correctly typed as PropTypes.string. Also check callers in NavigationBar to ensure they pass a string. A simple fix would be to adjust the prop type or add a default.