Kovah/LinkAce

Add support for password files

Open

#199 opened on Dec 31, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)PHP (1,761 stars) (111 forks)batch import
EnhancementHelp wanted

Description

Is your feature request related to a problem? Please describe. Specifying passwords in environment variables is not always the best available approach. Docker swarm, for example, has support for the concepts of secrets. These are in-memory files mounted in containers under /var/run. To support the use of these secrets, an app must support reading passwords from files.

Describe the solution you'd like Add support for DB_PASSWORD_FILE and DB_REDIS_PASSWORD_FILE environment variables that, if set, will read the passwords from the specified path instead of the regular environment variables.

Describe alternatives you've considered Using the .env file, but it doesn't solve the issue as Docker's secret management can't be used with it.

Additional context None.

Contributor guide

Tech stack
None
Domain
backendsecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
knowledge of PHP environment variable handlingfamiliarity with Docker secrets
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate how environment variables like DB PASSWORD are currently read in the codebase, likely in config/database.php or similar. Then implement logic to check for DB PASSWORD FILE and read the file contents if set. Ensure to handle file not found errors gracefully. Review the two existing comments in the issue for any additional clarification.