Kong/kubernetes-ingress-controller

Webhook integration/e2e tests don't run on GKE (disabled on all but kind)

Open

#1,613 opened on Jul 30, 2021

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Go (619 forks)auto 404
area/debthelp wantednice-to-haveonboardingpriority/low

Repository metrics

Stars
 (2,404 stars)
PR merge metrics
 (PR metrics pending)

Description

Current Behavior

When we originally wrote the webhook integration and e2e tests a hack was used to make them work in the kind environment. These tests do not work against other cluster implementations that are now provided by our testing framework, such as GKE due to these hacks.

Expected Behavior

The webhook integration and e2e tests should be able to run on any backend Cluster type that KTF supports.

Steps To Reproduce

1. create a GKE cluster in KTF
2. run the integration tests with the GKE cluster
3. run the e2e tests with the GKE cluster

Kong Ingress Controller version

v2.0.0-alpha.2

Kubernetes version

v1.20.5

Anything else?

  • remove the t.Skip() that was put in place in the tests when the cluster.Type() != "kind"

Contributor guide

Research direction
Investigate how KTF provides different cluster types, identify the kind specific hacks in webhook tests, and modify the tests to work with GKE and other backends.
Tech stack
go
Domain
backendinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoKubernetes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70