Knockout-Contrib/Knockout-Validation

Trailing dots in localization files

Open

#493 opened on Dec 25, 2014

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (394 forks)batch import
help wanted

Repository metrics

Stars
 (1,024 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The localization files have trailing dots but they are not consistent. For example, the messages in src/rules.js file all have dots at the end, but the messages in en-US.js do not. Everyone seeing this issue, please provide some feedback on this to decide in which direction to go:

  • with trailing dots.
  • without trailing dots

Contributor guide

Research direction
Review the localization files, decide on a consistent style (with or without trailing dots), and update all files accordingly.
Tech stack
javascript
Domain
internationalization
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90