Knockout-Contrib/Knockout-Validation

Too much recursion on deep grouping?

Open

#413 opened on Mar 18, 2014

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (1,024 stars) (394 forks)batch import
help wanted

Description

I have just updated to the new version so that I can validate elements within observable arrays.

Now I have added the grouping: { deep: true } to the configuration, and when I trigger validation the entire page locks up and then after about 5 seconds I get the error too much recursion.

Now I understand what the error means, its going too far down the tree when evaluating observables, and while my models are large they are not SUPER huge. So I am a bit baffled as to why it would cause this.

My object looks something like:

  • Character
    • Details (Pojo)
    • Notes (Pojo)
    • Credentials (Pojo)
    • Stats (Pojo)
    • Status (Pojo)
    • Skills (ObservableArray of Pojos, usually has about 10)
    • Powers (ObservableArray of Pojos, can have N amount, in this example has 1)
    • Items (ObservableArray of Pojos, can have N amount, in this example has 0)
    • Attacks (ObservableArray of Pojos, can have N amount, in this example has 1)

So I would not see this as a HUGE model, nor would I expect it takes that long to scan as it would only end up going down 2 levels as no Pojos contain any observable arrays. So is there anything else I should be doing or does it take significantly longer to do scans with observable arrays?

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Knockout.jsKnockout Validationunderstanding of deep groupingdebugging recursion
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the deep grouping logic in Knockout Validation's source code, likely in the validation engine that traverses observable hierarchies. Look for recursive calls that may cause stack overflow with deep or circular structures. The issue mentions using `grouping: { deep: true }` and having observable arrays of Pojos. Check the source files related to deep grouping (e.g., `src/grouping.js` or similar) and the recursion limit. Review existing comments in the issue for any attempted solutions or maintainer guidance.