Knockout-Contrib/Knockout-Validation

Validation on nested objects not working after changing whole object

Open

#398 opened on Jan 28, 2014

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (394 forks)batch import
help wanted

Repository metrics

Stars
 (1,024 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi, I have a problem with validating nested objects. I have following view model:

      var ViewModel = function (first) {
           this.person = ko.observable(new Person(first));

           this.changePerson = function () {
               this.person(new Person("changed"));
           };
      };

      var Person = function (first) {
           this.firstName = ko.observable(first).extend({
                required: true
           });
      };

everything works as expected as long as I do not call changePerson function. After calling change if I have element with data-bind="person().firstName" validation messages will not show. Working example (http://jsfiddle.net/MDhUR/). I found a work round to this issue - if I use to bind to firstName everything works as expected (http://jsfiddle.net/seRr5/1/) .

regards.

Contributor guide

Research direction
Investigate why validation is not triggered when replacing the entire person observable with a new object. Check if the new Person instance needs to be re validated or if the validation library extends the observable properties correctly on replacement.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptKnockout.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65