Files coverage computation error

Open Beginner friendly
#3,787 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
javascript
Domain
testing-qa

Research direction

Start in resources/js/vue/components/BuildCoveragePage.vue around lines 344-350, where the file coverage computation is identified. Compare the result for empty files and non-empty files with zero coverage against the stated expectations, then verify that the displayed overall file coverage reflects those cases correctly.

Written by the indexing model from the issue text.

Description

bug report

Bug report

Looking at the my file coverage percentage and comparing it to the actual individual file coverage I believe the result does not reflect the reality. At least not my interpretation of "a file is covered".

  • Empty files should be considered covered: 0 / 0 correctly gives 100% file coverage but seem to count as an uncovered file
  • Non-empty zero-coverage files should be considered uncovered: 0 / N correctly gives a 0% file coverage but seems to count as a covered file

Relevant logic seems to be here:
https://github.com/Kitware/CDash/blob/94d115a8aa03fa130692a6708a5a932fc88052ce/resources/js/vue/components/BuildCoveragePage.vue#L344-L350

CDash Version

v5.0.0

Dominant language
PHP
Stars
248
Forks
83
Avg merge
12h 9m
Merged PRs (30d)
47

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Kitware/CDash

All issues in Kitware/CDash

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.