Animations section image refers to node IDs instead of indices

Open Beginner friendly
#106 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
85/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Quiet
Domain
documentation

Research direction

Open gltfTutorial/gltfTutorial_007_Animations.md and locate Image 7b in the Animation Channels section. Update the image so the animation channel target uses the glTF 2.0 node index rather than an id string, then verify the rendered tutorial shows the corrected property.

Written by the indexing model from the issue text.

Description

The Image 7b at https://github.com/KhronosGroup/glTF-Tutorials/blob/main/gltfTutorial/gltfTutorial_007_Animations.md#animation-channels suggests that the animation channel target contains an id property that is a string.

This is a leftover from glTF 1.0 👴 In glTF 2.0, this id was replaced by node, which is an index into the nodes array of the glTF.

The image should be updated accordingly.

Dominant language
Python
Stars
1.3k
Forks
215
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from KhronosGroup/glTF-Tutorials

All issues in KhronosGroup/glTF-Tutorials

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.