Complete quoting for parameters of some CMake commands
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 64/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cmake
- Domain
- build-system
Research direction
Start in CMakeLists.txt, especially the commands and parameters at lines 33-52, then read the linked CMake list documentation about quoting. Update the affected command arguments so variable values containing special characters remain safe, and verify that the project configures and builds successfully.
Written by the indexing model from the issue text.
Description
Some parameters (like “${CMAKE_CURRENT_SOURCE_DIR}/dfd2vk.inl”) are passed to CMake commands in your build script without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.
I would recommend to apply advices from the software documentation.
- Dominant language
- C++
- Stars
- 8
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from KhronosGroup/dfdutils
-
c++ 20 raises a warning for "bitwise operation between different enumeration types ... deprecated" Open
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
KhronosGroup/dfdutils#15 · 3 comments ·
All issues in KhronosGroup/dfdutils
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
NVIDIA/cuda-samples#453 ·