KhronosGroup/SPIRV-LLVM-Translator

[Coverity] Copy instead of move

Open

#3,180 opened on May 16, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)LLVM (270 forks)auto 404
buggood first issue

Repository metrics

Stars
 (616 stars)
PR merge metrics
 (PR metrics pending)

Description

See issues at https://scan.coverity.com/projects/intel-llvm?tab=overview

CID 489856:

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blame/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/SPIRVWriter.cpp#L2430

CID 489869:

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blame/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/SPIRVWriter.cpp#L6425

CID 490409:

This one looks a bit weird to me, not sure if its a valid hit:

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blame/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/SPIRVWriter.cpp#L5148

CID 490034:

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVEntry.cpp#L637

CID 490504:

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVInstruction.h#L1197

CID 490545:

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVInstruction.h#L1804

CID 489914:

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVModule.cpp#L718

CID 490348:

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVUtil.h#L164

CID 439509:

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVUtil.h#L167

CID 489584:

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/590068b12402262dd9bd0aa1386f2e89babfa8a1/lib/SPIRV/libSPIRV/SPIRVValue.h#L310

Contributor guide

Research direction
Review each Coverity CID link, examine the code at the line, and determine if a copy can be replaced with std::move. Apply changes for each valid case.
Tech stack
cpp
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++move semantics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60