Khan/genqlient

Be less strict about selection-set ordering

Open

#93 opened on Sep 15, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (141 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (1,310 stars)
PR merge metrics
 (PR metrics pending)

Description

For both the bindings option, and the soon-to-be-added typename option, we validate that two selection sets are equal. Right now we demand that they even have the fields in the same order; ideally we'd allow any equivalent selections. That's surprisingly much work, although it's quite well separated from the rest of the codebase (just modify selectionsMatch in generate/validation.go).

Contributor guide

Research direction
Modify the `selectionsMatch` function in `generate/validation.go` to compare selection sets regardless of field order. Consider using a set based comparison rather than sequential order. Test with equivalent selections in various orders.
Tech stack
go
Domain
tooling
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60