Khan/genqlient

Hide __typename field if not user requested

Open

#61 opened on Aug 24, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Go (141 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (1,310 stars)
PR merge metrics
 (PR metrics pending)

Description

If you request some field of interface type, we automatically add __typename to your selection, so we can use the right type. But you probably don't need that field in your structs; you can always switch on the Go type! So ideally we should omit it from the generated structs. This isn't hard in principle, it's just some awkward plumbing since the place where we need to add it and the place where we need to ignore it are not very close together.

Contributor guide

Research direction
Identify where typename is added to selections (query generation) and where structs are generated. Add logic to omit typename unless user explicitly requests it, passing a flag between the two locations.
Tech stack
go
Domain
apibackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75