Khan/genqlient

Make it easier to integration test config options

Open

#261 opened on Mar 1, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (141 forks)github user discovery
help wantedinternalneeds design

Repository metrics

Stars
 (1,310 stars)
PR merge metrics
 (PR metrics pending)

Description

Our integration tests all run with a single config, which makes it hard to integration test a change like #252. Ideally we should do some reworking so we can test them against several configs, like we do in the snapshot tests. We'll have to think about what the best way is.

Once we do, we should add integration tests for #252, which should be fairly easy once the tooling is there.

Contributor guide

Research direction
Study the existing integration test setup in genqlient. Understand how snapshot tests handle multiple configurations. Propose and implement a way to run integration tests against multiple configs. Then add integration tests for the change in issue #252.
Tech stack
go
Domain
testing
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65