Khan/genqlient

Make it possible to ask for a *[]T

Open

#16 opened on Apr 22, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (141 forks)github user discovery
enhancementhelp wantedneeds use cases

Repository metrics

Stars
 (1,310 stars)
PR merge metrics
 (PR metrics pending)

Description

If you put pointer: true on a list-field, you get []*T (or [][]*T, or...) which is probably what you wanted (so you can represent an required list of optional items, for example, but not the only option. If anyone finds a reason to want *[]T, or for that matter *[][]*[]T, we can figure out a syntax for it; it's easy enough to do technically. (Although it won't be totally trivial if T is an interface.)

Contributor guide

Research direction
Study the current code generation for pointer types in genqlient, specifically how `pointer: true` produces `[]*T`, and explore how to add support for `*[]T` by modifying the code generation logic.
Tech stack
go
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45