Khan/genqlient

Correctly handle self-recursive types automatically

Open

#152 opened on Nov 2, 2021

View on GitHub
 (2 comments) (7 reactions) (0 assignees)Go (141 forks)github user discovery
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (1,310 stars)
PR merge metrics
 (PR metrics pending)

Description

(Split from #149.)

If you have in your schema

input T {
  f: T  # or `f: T!`
}

then genqlient by default generates

struct T {
  F T
}

which does not compile. Of course you can manually add pointer: true, but we could just do that automatically because it's the only valid way to represent this. Apparently this comes up a lot with Hasura-generated schemas, so although it seems a bit special-casey it's probably worth handling.

Contributor guide

Research direction
Trace the code generation logic for input types in genqlient to see how struct fields are generated, and implement automatic pointer addition for self recursive type fields.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGraphQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70