Karumi/Dexter

onPermissionDenied is called even when the permission was already granted

Open

#261 opened on Jun 10, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (5,224 stars) (682 forks)batch import
bughelp wanted

Description

Expected behaviour

I have an app that connects to Google Fit and in order to do that I need the Activity_Recognition permission, I ask it the first time the user connects, and, afterwards if I check it again it should say that the permission was granted.

Actual behaviour

What is actually happening is that If I try to check again the onPermissionDenied will be called.

Steps to reproduce

Call the first time it:

                .withPermission(Manifest.permission.ACTIVITY_RECOGNITION)
                .withListener(CompositePermissionListener(GoogleFitPermissionListener(rootView, activity, onSuccessAction),
                        SnackbarOnDeniedPermissionListener.Builder.with(rootView, activity.getString(R.string.google_fit_data_body, BuildConfig.NAME, BuildConfig.NAME, BuildConfig.NAME))
                                .withOpenSettingsButton(R.string.tracker_disconnect_gf_settings)
                                .build()))
                .check()

and then the second time you check it the onPermissionDenied will becalled, even though the user accepts the first time.

Version of the library

6.2.0

Contributor guide

Tech stack
javaandroid
Domain
mobileauthorization
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android developmentJavaDexter library usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue likely lies in the permission checking logic within the Dexter library. Start by examining the main check method in the Dexter class and the PermissionListener interface. Look at how the library determines whether to call onPermissionDenied vs onPermissionGranted. Check if there's a caching mechanism for permission state that might be failing. Also review any existing tests for the permission check flow to understand expected behavior.