Karumi/Dexter

Library should provide proper message if permission declaration doesn't exist on AndroidManifest.xml

Open

#229 opened on Jan 25, 2019

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Java (5,224 stars) (682 forks)batch import
enhancementhelp wanted

Description

Expected behaviour

If any permission has requested on the code but hasn't declared on the manifest. We should provide a proper message to declare permission on manifest

Actual behaviour

Not showing any message to declare in manifest

Steps to reproduce

Execute the code without declaring camera permission on the manifest.

     Dexter.withActivity(context)
            .withPermission(Manifest.permission.CAMERA)
            .withListener(object : PermissionListener {
                override fun onPermissionGranted(response: PermissionGrantedResponse) {
                }

                override fun onPermissionDenied(response: PermissionDeniedResponse) {
                }

                override fun onPermissionRationaleShouldBeShown(
                    permission: com.karumi.dexter.listener.PermissionRequest,
                    token: PermissionToken
                ) {
                }
            }).withErrorListener {

            }.check()

Version of the library

5.0.0

Contributor guide

Library should provide proper message if permission declaration doesn't exist on AndroidManifest.xml · Karumi/Dexter#229 | Good First Issue