Kareadita/Kavita

Missing image that occurs when a non-English or numeric file name exists in a compressed file

Open

#2234 opened on Aug 24, 2023

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C# (10,538 stars) (598 forks)batch import
bughelp wanted

Description

test2.zip The uploaded file is a test compression file. You can reproduce the same phenomenon with these files. If you go to the actual cache folder, you can see that two image files are missing. There seems to be a person who has similar symptoms on the discord channel. Originally, it was right to attach a log, but I couldn't upload it because there was no record in the log.

Tested at version 0.7.7 and docker environment. Host os is ubuntu 22.04 The client environment is windows 11 22H2 I tested with the latest version of Chrome and Edge.

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with C# file I/OUnderstanding of compressed file extractionAbility to run Kavita locally
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate how Kavita extracts files from compressed archives (likely using a library like SharpCompress or similar). Look for code that handles file names, particularly non ASCII or numeric filenames. Check if there is any encoding conversion or sanitization. Review the extracted file path generation to ensure it can handle different character sets. The provided test zip can be used to reproduce the issue.