"Frequency" used in place of "phase" in Seasonality tutorial

Open
#468 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
52/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
jupyter-notebook
Domain
documentation

Research direction

Locate the Seasonality lesson and its fourier_features() example. Read how the freq parameter is described and used, paying attention to the days-per-cycle units and the issue's phase-versus-period terminology. Done means the example uses consistent terminology without changing its intended behavior.

Written by the indexing model from the issue text.

Description

In the fourier_features() example algorithm on the Seasonality lesson of the Time Series course, the variable name freq is given to a parameter which takes units of days/cycle. This was confusing to me at first, because unless I'm mistaken, frequency typically refers to measurements given in inverse units (cycles/day), whereas period refers to time per cycle.

Dominant language
Jupyter Notebook
Stars
515
Forks
274
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Kaggle/learntools

All issues in Kaggle/learntools

Similar issues

More Documentation issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.