Julia 1.13 tests: Macro analysis - docstrings · JuliaPluto/Pluto.jl#3449

(2 comments) (0 reactions) (0 assignees)Julia (5,295 stars) (329 forks)batch import
buggood first issuemacro
Description

Test failure:

Doc strings: Test Failed at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:874
  Expression: occursin("::Bool", bool.output.body)
   Evaluated: occursin("::Bool", "f (generic function with 1 method)")
  Stacktrace:
   [1] top-level scope
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:7
   [2] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [3] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:849 [inlined]
   [4] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [5] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:874 [inlined]
   [6] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:753 [inlined]

Doc strings: Test Failed at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:876
  Expression: occursin("::Bool", int.output.body)
   Evaluated: occursin("::Bool", "f (generic function with 2 methods)")
  Stacktrace:
   [1] top-level scope
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:7
   [2] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [3] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:849 [inlined]
   [4] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [5] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:876 [inlined]
   [6] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:753 [inlined]

Doc strings: Test Failed at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:877
  Expression: occursin("::Int", int.output.body)
   Evaluated: occursin("::Int", "f (generic function with 2 methods)")
  Stacktrace:
   [1] top-level scope
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:7
   [2] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [3] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:849 [inlined]
   [4] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [5] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:877 [inlined]
   [6] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:753 [inlined]

Doc strings: Test Failed at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:885
  Expression: occursin("::Bool", int.output.body)
   Evaluated: occursin("::Bool", "f (generic function with 2 methods)")
  Stacktrace:
   [1] top-level scope
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:7
   [2] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [3] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:849 [inlined]
   [4] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [5] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:885 [inlined]
   [6] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:753 [inlined]

Doc strings: Test Failed at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:886
  Expression: occursin("::Int new docstring", int.output.body)
   Evaluated: occursin("::Int new docstring", "f (generic function with 2 methods)")
  Stacktrace:
   [1] top-level scope
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:7
   [2] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [3] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:849 [inlined]
   [4] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [5] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:886 [inlined]
   [6] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:753 [inlined]

Doc strings: Test Failed at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:890
  Expression: occursin("::Bool", bool.output.body)
   Evaluated: occursin("::Bool", "f (generic function with 2 methods)")
  Stacktrace:
   [1] top-level scope
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:7
   [2] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [3] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:849 [inlined]
   [4] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [5] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:890 [inlined]
   [6] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:753 [inlined]

Doc strings: Test Failed at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:891
  Expression: occursin("::Int new docstring", bool.output.body)
   Evaluated: occursin("::Int new docstring", "f (generic function with 2 methods)")
  Stacktrace:
   [1] top-level scope
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:7
   [2] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [3] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:849 [inlined]
   [4] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [5] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:891 [inlined]
   [6] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:753 [inlined]

Doc strings: Test Failed at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:892
  Expression: length(eachmatch(r"Bool", bool.output.body) |> collect) == 1
   Evaluated: 0 == 1
  Stacktrace:
   [1] top-level scope
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:7
   [2] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [3] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:849 [inlined]
   [4] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [5] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:892 [inlined]
   [6] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:753 [inlined]

Doc strings: Test Failed at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:893
  Expression: length(eachmatch(r"Int", bool.output.body) |> collect) == 1
   Evaluated: 0 == 1
  Stacktrace:
   [1] top-level scope
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:7
   [2] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [3] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:849 [inlined]
   [4] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [5] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:893 [inlined]
   [6] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:753 [inlined]

Doc strings: Test Failed at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:897
  Expression: length(eachmatch(r"Bool", bool.output.body) |> collect) == 1
   Evaluated: 0 == 1
  Stacktrace:
   [1] top-level scope
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:7
   [2] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [3] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:849 [inlined]
   [4] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [5] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:897 [inlined]
   [6] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:753 [inlined]

Doc strings: Test Failed at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:911
  Expression: occursin("An empty conjugate", bool.output.body)
   Evaluated: occursin("An empty conjugate", "")
  Stacktrace:
   [1] top-level scope
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:7
   [2] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [3] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:849 [inlined]
   [4] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [5] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:911 [inlined]
   [6] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:753 [inlined]

Doc strings: Test Failed at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:912
  Expression: occursin("complex conjugate", bool.output.body)
   Evaluated: occursin("complex conjugate", "")
  Stacktrace:
   [1] top-level scope
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:7
   [2] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [3] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:849 [inlined]
   [4] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:1961 [inlined]
   [5] macro expansion
     @ ~/Documents/Pluto.jl/test/MacroAnalysis.jl:912 [inlined]
   [6] macro expansion
     @ ~/.julia/juliaup/julia-1.13.0-beta1+0.aarch64.apple.darwin14/share/julia/stdlib/v1.13/Test/src/Test.jl:753 [inlined]
Test Summary:                                               | Pass  Fail  Broken  Total     Time
Macro analysis                                              |  165    12       1    178  2m35.5s
  Base macro call                                           |    8                    8     2.5s
  User defined macro 1                                      |    4                    4     0.6s
  User defined macro 2                                      |    7                    7     0.8s
  User defined macro 3                                      |    3                    3     0.8s
  User defined macro 4                                      |    1                    1     0.4s
  User defined macro 5                                      |    3                    3     0.5s
  User defined macro 6                                      |    2                    2     0.4s
  Function docs                                             |    2                    2     0.8s
  Expr sanitization                                         |    1                    1     0.3s
  Macrodef cells not root of run                            |    3                    3     0.5s
  Reverse order                                             |    7                    7     0.5s
  @a defines @b                                             |    9                    9     0.5s
  Removing macros undefvar errors dependent cells           |    4                    4     0.6s
  Redefines macro with new SymbolsState                     |    8                    8     0.9s
  Reactive macro update does not invalidate the macro calls |   11                   11     0.5s
  Explicitely running macrocalls updates the reactive node  |    7                    7     0.6s
  Implicitely running macrocalls updates the reactive node  |    8                    8     0.5s
  Weird behavior                                            |    5                    5     0.7s
  Cell failing first not re-run?                            |                  1      1     0.6s
  @a defines @b initial loading                             |    5                    5     0.4s
  Macro with long compile time gets function wrapped        |    9                    9     0.6s
  Macro Prefix                                              |    3                    3     5.2s
  Package macro 1                                           |    6                    6     1.2s
  Package macro 2                                           |   14                   14  2m07.9s
  Previous workspace for unknowns                           |    4                    4     1.2s
  Definitions                                               |    6                    6     0.5s
  Is just text macros                                       |    1                    1     0.6s
  Macros using import                                       |    2                    2     1.1s
  GlobalRefs in macros should be respected                  |    2                    2     0.6s
  GlobalRefs shouldn't break unreached undefined references |    2                    2     0.7s
  Doc strings                                               |   10    12             22     1.0s
  Delete methods from macros                                |    8                    8     1.4s
RNG of the outermost testset: Random.Xoshiro(0x6629de9ac6741e3d, 0x8a4a9c0770ecd165, 0x20f68005638a6c15, 0xcbd1eeea09a8e438, 0x3c97bb324e8cec5d)
ERROR: LoadError: Some tests did not pass: 165 passed, 12 failed, 0 errored, 1 broken.
in expression starting at /Users/fons/Documents/Pluto.jl/test/MacroAnalysis.jl:6
in expression starting at /Users/fons/Documents/Pluto.jl/test/runtests.jl:50
ERROR: Package Pluto errored during testing
Contributor guide

Tech stack: None
Domain: testing
Issue type: bug
Difficulty: 3
Estimated time: 1-3 hours
Activity status: fresh
Clarity: clear
Prerequisites: Julia programming languagePluto.jl basicsJulia macros and docstrings
Newbie friendliness: 60
Research direction: The test failures in test/MacroAnalysis.jl indicate that docstrings are not being correctly extracted from macro calls. The expected output should contain type annotations like '::Bool' and '::Int', but the actual output is either an empty string or a generic function signature. This may be due to changes in Julia 1.13 that affect macro expansion or docstring handling. Start by examining the test file at lines 849-911 to understand the test setup. Then look at the macro analysis source code in src/MacroAnalysis.jl to see how docstrings are processed. Check if there are any compatibility notes in the Pluto.jl documentation or recent commits related to Julia 1.13. Consider running the tests locally with Julia 1.13 to reproduce the issue.