JuliaPluto/Pluto.jl

Switch to @msgpack/msgpack-javascript

Open

#2394 opened on Nov 25, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Julia (5,295 stars) (329 forks)batch import
enhancementfrontendgood first issueperformance

Description

Right now we are using https://github.com/kawanet/msgpack-lite for the JS side of our MsgPack protocol, or actually, my fork https://github.com/fonsp/msgpack-lite/commit/699001171edfc1e990b14085917f869badfa4d5b where i directly edited the .min.js bundle to become an ES6 file 😅

It's working great, and I think it is quite fast.

We could switch to https://github.com/msgpack/msgpack-javascript , which is being actively developed, and more modern: it is written for ES6.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptmsgpack liteES6 modules
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue proposes switching from msgpack lite to @msgpack/msgpack javascript. First, identify all files that import or use msgpack lite, likely in the JavaScript bundle (e.g., in the frontend code). Then, compare the APIs of both libraries and replace usage accordingly. Ensure that the new library can be loaded as an ES6 module. Finally, run existing tests to verify the changes don't break functionality.