JuliaPluto/Pluto.jl

ExpressionExplorer: `global` stronger than `let`

Open

#1856 opened on Jan 26, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Julia (5,295 stars) (329 forks)batch import
backendbugexpression explorergood first issue

Description

We have a couple of combinations of let and global that are not analyzed correctly, like:

let
	a = 1
	global a = 2
end

defines a global a, but Pluto prioritizes the let block.

@test_broken means that we still need to fix it:

https://github.com/fonsp/Pluto.jl/blob/c1d23122845e7864ef3dfe15a8428366c98f95eb/test/ExpressionExplorer.jl#L368-L379

This is a good first issue, because the ExpressionExplorer is a small, isolated part of Pluto's codebase. For more info about working on this issue, see:

https://github.com/fonsp/Pluto.jl/blob/c1d23122845e7864ef3dfe15a8428366c98f95eb/test/ExpressionExplorer.jl#L3-L17

Contributor guide

Tech stack
None
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Julia basicslet vs global scoping
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine the `test/ExpressionExplorer.jl` file around lines 368-379 where `@test broken` is used. Understand the expected scoping behavior and identify the code in the ExpressionExplorer that handles `let` and `global` statements, then implement the fix and uncomment the test.