JuliaLang/julia

`parse` can't parse our own Float32 output format

Open

#5,690 opened on Feb 5, 2014

View on GitHub
 (17 comments) (0 reactions) (0 assignees)Julia (48,709 stars) (5,773 forks)batch import
good first issuehelp wanted

Description

This is unfortunate:

julia> float32("1f0")
ERROR: ArgumentError("float32(String): invalid number format")
 in float32 at string.jl:1567

Contributor guide

Tech stack
None
Domain
data
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JuliaFloat32 format knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the float32 parsing function in string.jl around line 1567. Understand why the format '1f0' is not recognized and modify the parsing logic to accept the standard Float32 output format as produced by Julia's print function.