JuliaLang/julia

Displaying array with unsigned indices throws

Open

#53,907 opened on Mar 31, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Julia (48,709 stars) (5,773 forks)batch import
display and printinggood first issue

Description

In the spirit of #44895, displaying an AbstractArray subtype with unsigned indices can throw an OutOfMemory exception. The offending lines are https://github.com/JuliaLang/julia/blob/a3f710e2a35402bb7f7f96f874e6c696dfc911da/base/arrayshow.jl#L138-L141 The max(0, difference of unsigned) is obviously not safe.

Contributor guide

Tech stack
None
Domain
performance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of Julia baseUnderstanding of unsigned integer overflow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the lines 138-141 in base/arrayshow.jl referenced in the issue. Understand the logic of displaying array indices and ensure safe subtraction when indices are unsigned. Consider using max(0, Int(difference)) or a similar safe conversion. Review the linked issue #44895 for context.