JuliaLang/julia

Displaying array with unsigned indices throws

Open

#53,907 opened on Mar 31, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Julia (5,773 forks)batch import
display and printinggood first issue

Repository metrics

Stars
 (48,709 stars)
PR merge metrics
 (Avg merge 20d 6h) (157 merged PRs in 30d)

Description

In the spirit of #44895, displaying an AbstractArray subtype with unsigned indices can throw an OutOfMemory exception. The offending lines are https://github.com/JuliaLang/julia/blob/a3f710e2a35402bb7f7f96f874e6c696dfc911da/base/arrayshow.jl#L138-L141 The max(0, difference of unsigned) is obviously not safe.

Contributor guide

Research direction
Investigate the lines in arrayshow.jl that calculate differences with unsigned indices. The fix likely involves converting to signed integers before subtraction or using a safe method to compute max(0, difference) that handles unsigned overflow.
Tech stack
julia
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JuliaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70