JuliaLang/julia

Dates round/floor/ceil arguments switched

Open

#47,786 opened on Dec 2, 2022

View on GitHub
 (7 comments) (4 reactions) (0 assignees)Julia (5,773 forks)batch import
datesgood first issuehelp wanted

Repository metrics

Stars
 (48,709 stars)
PR merge metrics
 (Avg merge 20d 6h) (157 merged PRs in 30d)

Description

round(T, x) is the normal API, but in Dates.jl the arguments are reversed.

julia> ceil(today(), Week)
2022-12-05

julia> ceil(Week, today())
ERROR: MethodError: no method matching ceil(::Type{Week}, ::Date)

Contributor guide

Research direction
Inspect the source code of the Dates module to locate the definitions of round, floor, and ceil functions. Identify the argument order and swap them to match the standard API pattern of func(x, T). Ensure consistency with other similar functions.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JuliaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75