JuliaDynamics/DynamicalSystemsBase.jl

Successful step function no longer works for parallel ODE system

Open

#214 opened on Jul 25, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Julia (34 forks)auto 404
good first issuetesting

Repository metrics

Stars
 (56 stars)
PR merge metrics
 (PR metrics pending)

Description

Hm, some update in the OrdinaryDiffEq.jl library broke this. So, in the test suite for the successful_step function the parallel ODE fails to convey that the steps take have failed. Perhaps this is related to the fact that we pass in a custom norm internalnorm = inorm when we create a parallel ODE system, here

https://github.com/JuliaDynamics/DynamicalSystemsBase.jl/blob/89fcd8be5e878e2ac275274e3a27b378ff9780f3/src/derived_systems/parallel_systems.jl#L63

but honestly I am not sure. What I am sure about is that the test fails:

https://github.com/JuliaDynamics/DynamicalSystemsBase.jl/blob/89fcd8be5e878e2ac275274e3a27b378ff9780f3/test/successful_step.jl#L21

which is why in the current code this is commented out. We will need to test whether this is truly an OrdinaryDiffEq.jl problem by simply making a MWE with an ODEProblem with a parallel rule for two states and passing in a modified internalnorm as a keyword argument. If it is an OrdinaryDiffEq.jl problem, we open an issue there with our MWE. If not, then we have to fix it here.

Contributor guide

Research direction
Create a minimal working example to determine whether the bug originates in OrdinaryDiffEq.jl or DynamicalSystemsBase.jl. Then act accordingly.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75