JuliaAnimators/Javis.jl

[BUG] Jupyter Caching gifs with Same Name

Open

#357 opened on Jul 4, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Julia (847 stars) (50 forks)batch import
bugdocumentationerror-handlinggood first issue

Description

Describe the bug

See discussion here: https://julialang.zulipchat.com/#narrow/stream/253420-javis.2Ejl/topic/Javis.20Jupyter.20Viewer.20Bug/near/244873375

To Reproduce

  1. Julia Version (i.e. output of julia -v): 1.6.0

  2. Operating system (Mac, Linux, Windows): Fedora 34 (linux)

  3. Javis version (i.e output of ] status Javis in the REPL): v0.5.2

  4. Minimum working code example that led to bug: https://github.com/mforets/escritoire/blob/8cd6c5a7a3a8f28a25d37bce4757c3dd5b2ba35d/2021/Week27/Javis_Test_1.ipynb

Expected Behavior and Actual Behavior

Object colors were not updated between running of Jupyter cells when animation was saved to previously rendered animation with the same name.

Additional context

See @mforets notebook here for the code that was causing this behavior https://github.com/mforets/escritoire/blob/8cd6c5a7a3a8f28a25d37bce4757c3dd5b2ba35d/2021/Week27/Javis_Test_1.ipynb

Contributor guide

Tech stack
None
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Julia basicsJavis libraryJupyter notebooks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the caching mechanism for gif rendering in Javis's Jupyter integration. Look at the code that handles saving animations and how it checks for existing files with the same name. The issue may be related to not clearing the previous gif's data. Check the referenced notebook and Zulip discussion for reproduction steps.