Juanpe/SkeletonView

Does not work with new UICollectionView Compositional Layout

Open

#321 opened on Sep 4, 2020

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Swift (1,125 forks)batch import
featurehelp wantedtriaged

Repository metrics

Stars
 (12,873 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

⚠️ Please fill out this template when filing an issue.

🙏🏼 Please check if it already exists other issue related with yours.

What did you do?

Implemented a UICollectionView using the new Compositional Layout feature.

Then added this to viewDidLoad()

DispatchQueue.main.async {
            self.collectionView.showSkeleton()
        }

What did you expect to happen?

Expected to see the skeleton view applied to the UICollectionView

What happened instead?

I assume that since UICollectionView implementations that use Compositional Layout use diffable datasources instead of implementing the CollecitonView data source the skeleton view was not applied to my collectionview cells.

Steps to reproduce the behavior

Implement a UICollectionView with Compositional Layout and try applying the SkeletonView

SkeletonView Environment

SkeletonView version: SkeletonView (1.8.8) Xcode version: 11.7 Swift version: 5.2

Contributor guide

Research direction
Investigate how SkeletonView attaches to UICollectionView data source methods and identify if it needs updates to support compositional layout and diffable data sources.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
iOSUICollectionView
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70