JanusGraph/janusgraph

hasId does not convert int to Long

Open

#1,554 opened on May 6, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Java (4,985 stars) (1,137 forks)batch import
area/corehelp wantedkind/enhancement

Description

If an int is passed instead of a String or a Long to hasId() it does not get converted and results won't be yielded. This behavior has been report in issue #706, but I think this would be a nice improvement.

I think looking at the HasStepFolder.foldInIds() method might be a good place to start.

Additional info can be found in this stack overflow question and this tinkerpop issue

Contributor guide

Tech stack
java
Domain
database
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java programmingFamiliarity with JanusGraph basicsUnderstanding of type conversion in Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Start by examining the `HasStepFolder.foldInIds()` method in `janusgraph core/src/main/java/org/janusgraph/graphdb/tinkerpop/optimize/HasStepFolder.java`. The issue indicates that when an int is passed to `hasId()`, it does not get converted to Long, causing no results. Review existing type conversion logic in that method and consider adding a check for int arguments. Also review linked issues #706 and TINKERPOP 2209 for additional context.