Should fail with original error
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start with operation_dispatcher.rb around line 30 and acts_as_resource_controller.rb around line 100, then review the referenced transaction behavior in the linked Rails change. Confirm that a transactional operation propagates its original exception rather than only ActiveRecord::Rollback, while non-transactional behavior remains unchanged.
Written by the indexing model from the issue text.
Description
In some cases original exceptions have important effects, for example I ran with issue that this fix is not working with jsonapi-resources "deallocate prepared statements if we fail inside a transaction"(https://github.com/rails/rails/pull/22170), so when you shallow error here you'd potentially breaks some other logic.
I think you should propagate original error, not just ActiveRecord::Rollback
Something like this should work, I think
https://github.com/cerebris/jsonapi-resources/blob/v0.9.0/lib/jsonapi/operation_dispatcher.rb#L30:
rollback(transactional) if results.has_errors? => fail results.original_error if results.has_errors? && transactional
- Dominant language
- Ruby
- Stars
- 2.3k
- Forks
- 546
- PR merge metrics
- No merged PRs in 30d
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from JSONAPI-Resources/jsonapi-resources
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
Difficulty 3/5 1-2 days Newbie friendliness 50/100
JSONAPI-Resources/jsonapi-resources#1488 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
JSONAPI-Resources/jsonapi-resources#1479 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
JSONAPI-Resources/jsonapi-resources#1477 · 3 comments · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
All issues in JSONAPI-Resources/jsonapi-resources
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
TheOdinProject/curriculum#31423 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
oxidize-rb/rb-sys#807 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day