Filter on relationship route?

Open

#1,065 opened on May 13, 2017 3 comments 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 3/5
Estimated time: 1-2 days
Newbie friendliness: 35/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Stale
Tech stack: rails, ruby
Domain: api

Research direction

Start with the PostResource records_for_comments method and compare filter handling for /comments?filter[active]=1 versus /posts/14/comments?filter[active]=1. Trace the nested relationship route entry point and confirm whether the CommentResource active filter is applied there; done means the nested route produces the same filtering behavior as the direct comments route.

Written by the indexing model from the issue text.

Description

Is it possible to filter on a relationship route?

class PostResource < JSONAPI::Resource
  has_many :comments

  def records_for_comments(options = {})
    records_for(:comments).public
  end
end

class CommentResource < JSONAPI::Resource
  has_one :post

  filter :active,
    apply: -> (records, value, options) {
      if value
        records.active
      else
        records.inactive
    end
  }
end

This calls the filter:

/comments?filter[active]=1

This does not seem to call the filter:

/posts/14/comments?filter[active]=1

Dominant language: Ruby
Stars: 2.3k
Forks: 546
PR merge metrics: No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

EVENTS: Access event question templates from above Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 82/100

hitobito/hitobito#4521 · Opened Sep 25, 2026
Symbol truncation can split multi-byte UTF-8 runes and cause valid profiles to be rejected Open

ai-generated

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

grafana/pyroscope#5691 · Opened Sep 25, 2026
Missing en translation: user.invalid_hash Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

exercism/website#9920 · Opened Sep 25, 2026
db commands hand psql the user and password still percent encoded Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 82/100

hanami/hanami-cli#449 · Opened Sep 25, 2026
Trie#find keeps every path it looks up, 404s included Open

Difficulty 2/5 1-3 hours Newbie friendliness 82/100

hanami/hanami-router#310 · Opened Sep 24, 2026

More Ruby issues