JSMonk/hegel

Relational operations should inferred for string as well

Open

#333 opened on Apr 17, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (2,047 stars) (55 forks)batch import
help wanted

Description

function le(a, b) {
    return a <= b
}

Actual: a and b infer as $StrictUnion<bigint | number>

Expected a and b infer as $StrictUnion<bigint | number | string>

Contributor guide

Tech stack
typescriptjavascript
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Hegel's type inferenceFamiliarity with relational operator type handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the type inference logic for relational operators in Hegel. Look at how the <= operator currently infers types and where string is missing. The fix likely involves updating the inference to include string in the union. Check the type system codebase for similar operator inference patterns.