Ionaru/easy-markdown-editor

CodeMirror.commands undefined when importing package

Open

#43 opened on Jan 7, 2019

View on GitHub
 (5 comments) (5 reactions) (0 assignees)JavaScript (355 forks)user submission
BugHelp wanted

Repository metrics

Stars
 (3,006 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I'm submitting a...

  • Bug report
  • Feature request

Reproduction steps

  1. Install package npm install --save easymde
  2. Use webpack to bundle your js and point it to an entrypoint javascript file.
  3. Import it in your JS file import "easymde" or import { EasyMDE } from "easymde" or import * as EasyMDE from "easymde"
  4. Visit page that JS is loaded, it will say CodeMirror.commands is undefined in browser console.

If I import the minified js file (see below) it works fine, so I guess the issue is related to the bundling, perhaps some dependency or something that have to be set in the webpack config file that is not specified?

const EasyMDE = require('easymde/dist/easymde.min.js');

Version information

Browser type and version: Chrome/Firefox EasyMDE version: 2.4.2

Contributor guide

Research direction
Examine how EasyMDE imports CodeMirror and ensure the package is properly configured for webpack bundling, possibly by adding CodeMirror as a dependency or adjusting the import path.
Tech stack
javascriptnodejs
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
npmwebpack
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60