IntersectMBO/plutus

Add golden tests for the validation benchmarks

Open

#6828 opened on Feb 10, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Haskell (1,637 stars) (511 forks)batch import
BenchmarksGood first issueInternalTeststatus: triagedtech debt

Description

Currently the validation benchmarks don't seem to have any golden tests ensuring that what scripts evaluate to doesn't change. Unlike e.g. nofib or bitwise benchmarks (and lists ones have some property tests). We should fix that, otherwise an apparent optimization might as well turn out to be a bug.

Same about marlowe?

Contributor guide

Tech stack
None
Domain
testingperformance
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
HaskellPlutus basicsgolden testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
First, examine how golden tests are implemented for the 'nofib' and 'bitwise' benchmarks in the same repository (e.g., look at the test files for those benchmarks). Understand the pattern: likely there is a script that outputs expected values and a test framework that compares against them. Then, apply the same pattern to the 'validation' benchmarks directory. The issue also mentions 'marlowe' so decide if it should be included. After writing the golden tests, run them to ensure they pass. If there are any failing tests, investigate whether the benchmarks produce deterministic output.