Instagram/Fixit

Add rule for fixing imports which use as with a no-op

Open

#171 opened on Jan 15, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (68 forks)auto 404
good first issuehelp wanted

Repository metrics

Stars
 (711 stars)
PR merge metrics
 (PR metrics pending)

Description

For example:

from example.fixit_ex import ExampleClass as ExampleClass

Should be:

from example.fixit_ex import ExampleClass

Because using as with the same resulting name is a no-operation action.

Contributor guide

Research direction
Implement a new lint rule in Fixit that detects when an import uses `as` with the same name (e.g., `from module import Name as Name`) and suggests removing the redundant `as` clause. Look at existing rules in the Fixit repository for patterns, especially those in `fixit/rules/`. Write tests following the project's conventions.
Tech stack
python
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80