Error in `make_catalog_reproduce.py` script

Open Beginner friendly
#41 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
python
Domain
data

Research direction

Open scripts/evobio10m/make_catalog_reproduce.py and inspect lines 115-126, starting with how taxon_data is produced and unpacked. Confirm the tuple shape for the two affected datasets, align the validation with that shape, and run the reproduction script to verify that the spurious logger errors no longer appear.

Written by the indexing model from the issue text.

Description

Hi,

It seems like there is an error in the following lines of the make_catalog_reproduce.py script:

https://github.com/Imageomics/bioclip/blob/c73811216eb63afcdb905d3d4283667c5c5bcd64/scripts/evobio10m/make_catalog_reproduce.py#L115-L126

There is first a check that the length of the taxon_data tuple is 2 but then it's unpacked to 3 values which doesn't make sense.

In practice there is indeed 3 values and the logger prints an error for every items in those two datasets.

Best,
Rémi

Dominant language
Python
Stars
278
Forks
26
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Imageomics/bioclip

All issues in Imageomics/bioclip

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.