run start/stops: fields that are required are not marked as required

Open Beginner friendly
#11 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Domain
data

Research direction

Compare the field declarations in schemas/pl72_run_start.fbs and schemas/6s4t_run_stop.fbs with the required-field syntax shown in schemas/ev44_events.fbs. Check the schema and file-ID compatibility implications before making any changes; done means the required fields are represented consistently and the versioning decision is documented or reflected in the change.

Written by the indexing model from the issue text.

Description

https://github.com/ISISComputingGroup/streaming-data-types/blob/master/schemas/pl72_run_start.fbs and https://github.com/ISISComputingGroup/streaming-data-types/blob/master/schemas/6s4t_run_stop.fbs don't use the (required) suffix after typing their fields, on required fields.

See ev44 which does use this syntax correctly

technically this is breaking but i don't know if we really want to change the file id and create a new schema or not - probably not.

Dominant language
Rust
Stars
0
Forks
0
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ISISComputingGroup/streaming-data-types

All issues in ISISComputingGroup/streaming-data-types

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.