ISISComputingGroup/genie

load_script type checking - allow `np` datatypes in `cset` / `PVValue`

Open

#59 opened on Oct 9, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (0 forks)auto 404
good first issue

Repository metrics

Stars
 (1 star)
PR merge metrics
 (PR metrics pending)

Description

As a user on MERLIN I would like the following snippet to pass type checking:

import numpy as np
from genie_python import genie as g

def runscript():
    for psi in np.arange(30,130,10):
        g.cset("Rot", psi, lowlimit=psi-0.1, highlimit=psi+0.1, runcontrol=True)

It currently fails with:

E: Argument of type "signedinteger[Any]" cannot be assigned to parameter "args" of type "PVValue"

PVValue should also include np types

Acceptance criteria

  • Above snippet passes type checking

Contributor guide

Research direction
Examine the type annotation for `PVValue` in the genie codebase and update it to accept numpy numeric types (e.g., `np.signedinteger`, `np.floating`) so that the `cset` function can accept such values.
Tech stack
pythonnumpy
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonNumPyType hints
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75