INRIA/spoon

feat: shadow classes should be closed to intercession

Open

#4,667 opened on Apr 6, 2022

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Java (383 forks)github user discovery
featuregood first issue

Repository metrics

Stars
 (1,933 stars)
PR merge metrics
 (Avg merge 19d 11h) (49 merged PRs in 30d)

Description

problem: the shadow classes (CtClass reflecting a binary class) built by JavaReflectionTreeBuilder can be modified. This is confusing for users, see https://github.com/INRIA/spoon/issues/4664.

solution: the JavaReflectionTreeBuilder should construct immutable objects, closed to modification, where all setters throw an UnsupportedOperationException

Contributor guide

Research direction
Implement immutability for shadow classes by modifying JavaReflectionTreeBuilder to return immutable CtClass instances where setter methods throw UnsupportedOperationException.
Tech stack
java
Domain
backendtooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaSpoon internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55