INRIA/spoon

fix static analysis warnings by SonarQube

Open

#2,228 opened on Jul 15, 2018

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Java (383 forks)github user discovery
good first issuerefactor

Repository metrics

Stars
 (1,933 stars)
PR merge metrics
 (Avg merge 19d 11h) (49 merged PRs in 30d)

Description

Warning list: https://sonarqube.ow2.org/project/issues?id=fr.inria.gforge.spoon%3Aspoon-core&resolved=false&types=BUG

I am using IDEA checkers to improve our code base but, at the same time some Sonar defects are solved as well (some checkers overlap).

I am going to fix all true positives on SonarQube on regular basis.

Today (2018-07-16) I am starting with 2076 issues to fix.

One more time I would like to get labels:

  • code inspection (yellow) - to mark IDEA inspections
  • sonarqube (orange) - to mark SonarQube inspections

to manage PRs with fixes. Also it would be change color of "bug" to RED :)

"refactor" label is better suited for refactoring of pure functionality (for instance: rework parser to support syntax X).

Contributor guide

Research direction
Review the SonarQube warning list, pick a specific bug warning, locate the corresponding code in the Spoon codebase, and apply the fix.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70