IDAES/idaes-pse

get_prop has incorrect default components

Open

#1,616 opened on Apr 24, 2025

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (314 forks)auto 404
Priority:Lowgood first issuemodels_extra

Repository metrics

Stars
 (330 stars)
PR merge metrics
 (PR metrics pending)

Description

As noted in #1613 , get_prop for the natural_gas_pr.py properties in models_extra incorrectly writes:

    if components is None:
        components = list(_component_params.keys())

for the default components. The correct statement is

    if components is None:
        components = list( comp for comp in _component_params.keys())

This error should be remedied and a test should be added.

Contributor guide

Research direction
Locate the `get prop` function in `natural gas pr.py` and examine the line where default components are set. Correct the list comprehension and add a unit test to verify the fix.
Tech stack
python
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75