IDAES/idaes-pse

MSContactor and phase_frac

Open

#1,573 opened on Feb 20, 2025

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Python (314 forks)auto 404
PrOMMiSPriority:Lowbuggood first issue

Repository metrics

Stars
 (330 stars)
PR merge metrics
 (PR metrics pending)

Description

Presently, the MSContactor model adds phase fraction variables whether or not they already exist on a StateBlock. As a result, it cannot be used with property packages that already have a phase_frac variable, such as the entire modular property framework. All that's needed to fix this issue is to add a check to see if phase_frac already exists (this approach is already implemented in the ControlVolume blocks).

Contributor guide

Research direction
Inspect the MSContactor model to add a check for existing phase frac variables, similar to ControlVolume blocks.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75