HuskieRobotics/SPOT

refactor authentication and demo-mode to use middleware

Open

#120 opened on Jun 18, 2024

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)JavaScript (29 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (27 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently, every admin and setup endpoint checks for authentication. It would be cleaner if authentication was checked once with a middleware approach and all endpoints wouldn't have to worry about it. Similarly, demo-mode is checked throughout admin and scouting endpoints and that could be done in a single place using middleware.

Contributor guide

Research direction
Identify all endpoints that currently check authentication and demo mode, then define a middleware that performs these checks and apply it to the appropriate routes.
Tech stack
javascript
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60