HuskieRobotics/3061-lib

the Drivetrain's getRotation method may return angles > 360°

Open

#39 opened on Jun 3, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (17 forks)auto 404
help wanted

Repository metrics

Stars
 (32 stars)
PR merge metrics
 (PR metrics pending)

Description

The Rotation2d class doesn't constrain the range of angles. The Drivetrain class' getRotation method may return angles greater than 360°. We need to carefully consider what the intended behavior should be.

Contributor guide

Research direction
Examine the Rotation2d class to understand how angles are stored. Then check where Drivetrain.getRotation is used and decide whether to normalize the angle or report raw. Consider if the expected range is [0,360) or ( 180,180]. Look for similar issues in the repository.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Java
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80