DeprecationWarning: HTTPResponse.getheaders() is deprecated and will be removed in urllib3 v2.1.0. Instead access HTTPResponse.headers directly
@alzheltkovskiy-hubspot is already working on this.
Since Dec 13, 2024.
Assessment
This issue has not been assessed yet.
Description
Hi 👋
Using hubspot-api-client 8.0.0 and urllib3 1.26.16, I get these warnings:
hubspot/crm/contacts/rest.py:41: DeprecationWarning: HTTPResponse.getheaders() is deprecated and will be removed in urllib3 v2.1.0. Instead access HTTPResponse.headers directly.
return self.urllib3_response.getheaders()
hubspot/crm/contacts/rest.py:45: DeprecationWarning: HTTPResponse.getheader() is deprecated and will be removed in urllib3 v2.1.0. Instead use HTTPResponse.headers.get(name, default).
return self.urllib3_response.getheader(name, default)
These warnings also come from:
hubspot/communication_preferences/rest.py:41
hubspot/communication_preferences/rest.py:45
hubspot/crm/associations/rest.py:45
hubspot/crm/deals/rest.py:45
hubspot/crm/objects/rest.py:45
hubspot/discovery/discovery_base.py:1
and so on...
See other deprecations with urllib3 2.0.0 here. And urllib3 2.1.0 is planned to be released in the summer of 2023.
Resolving these deprecation warnings will prepare hubspot-api-client to be ready for future versions of urllib3. A plan for package maintainers is described here.
I'll be happy to contribute with a PR. Regarding the maintenance of the project, I see most files have Generated by: https://openapi-generator.tech, but I don't see instructions on how to regenerate those files. To fix the issue mentioned here, should we regenerate the files with an updated OpenAPI Generator?
- Dominant language
- Python
- Stars
- 434
- Forks
- 126
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from HubSpot/hubspot-api-python
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
HubSpot/hubspot-api-python#497 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
HubSpot/hubspot-api-python#498 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
HubSpot/hubspot-api-python#496 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
HubSpot/hubspot-api-python#495 · 1 comment · 2 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
HubSpot/hubspot-api-python#494 ·
All issues in HubSpot/hubspot-api-python
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
xinnan-tech/xiaozhi-fde-talk#263 ·
-
rules
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
huggingface/Repo2RLEnv#163 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 95/100
huggingface/sentence-transformers#4074 ·
-
comp/dashboard invalid P3
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
NousResearch/hermes-agent#121143 ·