HeroTransitions/Hero

Animation doesn't work when navigationController pushing screen

Open

#753 opened on Nov 14, 2022

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Swift (1,735 forks)batch import
confirmed buggood first issueneed help

Repository metrics

Stars
 (22,453 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Why Hero Transition Animation doesn't work when I push a new viewController into UINavigationController or setting as a root view controller?

Contributor guide

Research direction
Check if hero.isEnabled is set and heroID is properly assigned to both view controllers. Ensure the navigation controller delegate is set to HeroNavigationController. Debug by applying a simple animation on push without navigation controller to isolate.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftiOSHero
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75