HeroTransitions/Hero

Hero makes my CAEmitterLayer work inconsistently

Open

#716 opened on Mar 17, 2021

View on GitHub
 (5 comments) (2 reactions) (1 assignee)Swift (1,735 forks)batch import
confirmed buggood first issueneed help

Repository metrics

Stars
 (22,453 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What did you do?

Hi, many thanks to all the people maintaining the library and providing support ❤️. I use a CAEmitterLayer to make some confettis pop as soon a view is displayed. When Hero is used to transition (with an animation) to the view controller containing the CAEmitterLayer, Confettis will be emitted (that's ok) but when you repeat the process (dismiss the controller then show it again) : Confettis will never be emitted again! TL:DR : As soon as Hero is used to do something in the app, my CAEmitterLayer will work inconsistently.

What did you expect to happen?

The CAEmitterLayer emitting confettis every time the view controller is displayed.

What happened instead?

The CAEmitterLayer will emit confettis the first time the controller is displayed, sometimes the second time and never again!

General Information

  • Hero Version: 1.6.1

  • iOS Version(s): 14.4

  • Swift Version: 5.3

  • Devices/Simulators: All

  • Reproducible in Examples? (Yes/No): Yes

Demo Project

Note : If you deactivate the hero navigationAnimationType in the ViewController, everything will work as expected.

caemitterlayerbug.zip

Contributor guide

Research direction
Investigate how Hero transitions manipulate CAEmitterLayer. Check if Hero resets or removes the emitter layer during transition completion, causing it to stop emitting on subsequent displays.
Tech stack
swift
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
iOS developmentCore AnimationHero library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60